shiptest-ss13
Supercharged Flavourtext + Subtle Emote Refactor (again)
About The Pull Request
Moves flavourtext to TGUI, adding the ability to use markdown formatting and a character image (ONLY from imgur at the moment). Also refactors subtle emote to just be a version of normal emoting instead of weird separate somewhat-duplicate code.
TODO: Currently has two different versions, basically a better version of the old system, and the new TGUI system that uses a component. The first is accessed like normal, while the new system is accessed by examine-more-ing a human.
I can't actually test this because neither images nor the markdown parser works on wine lmao
Why It's Good For The Game
I always thought flavourtext and subtle emotes were rather neglected. This improves them a little bit at least.
Changelog
:cl: add: TGUI flavourtext and character images, which can be viewed by double-examining someone. /:cl:
soon......:tm: I think it actually works-ish now I just need to test it on my windows machine lol
graahhhhhh also testing never happened on my end because my one remaining windows machine is now also a linux machine
Good pr, I love flavor text. However, there's an issue where attempting to add an image caption to any portrait will immediately set that as the caption for all image portraits.
https://github.com/user-attachments/assets/5c503511-53c4-44bb-b56f-eb757dc797cc
I think I may have fixed both the issues with it saving and it setting for all characters in one go, but I'm not certain.
awesome awesome! out of curiosity, did the new input window for the flavortext work?
It produced an NTOS error whenever I tried to input anything or left it open for a few seconds. I chalked it up to VScode running the game weirdly since some other errors appeared that don't usually when I just run the DM executable. The images themselves also didn't appear in the FT, but again, I blamed it on VScode.
This pull request has conflicts, please resolve those before we can evaluate the pull request.
![github-actions[bot] avatar](https://avatars.githubusercontent.com/in/15368?v=4 "Published by a pub.dev verified publisher"){kind=small}
so yeah by that I mean it's ready for testmerge again. and I actually tested it fully this time
double examining is ALSO used to thoroughly inspect injuries on people like bleeding and wounds (not ideal to have another window pop up in the middle of a tense scenario)
okay yeah that's fair in my defense when I first made this we didn't have wounds so it WAS free. I'll move it back to only being the link in examine
alright, moved it back to being a link in examine (though I did integrate it better into the component itself) as well as resized the window which was too small to fit the entirety of the image by mistake.
This pull request has conflicts, please resolve those before we can evaluate the pull request.
agh ogh. will fix conflicts and make it update less laggily in a bit