Shiptest icon indicating copy to clipboard operation
Shiptest copied to clipboard

Removes ORM from non-mining/salvage ships.

Open Sadhorizon opened this issue 1 year ago • 6 comments

About The Pull Request

Removes the ORM from Beluga, Box, Schmiedeberg, Colossus, Skipper and Kansatsu.

Aspawn ships, Hyena and Gecko still have it.

Images of changes:

(totally not just mapdiffbot)

obraz

obraz

obraz

Why It's Good For The Game

They have no reason to have an ORM! They are not mining/salvage-centered ships, so they can totally go to the outpost to refine their ore! (it's a Dwayne buff in disguise :3)

Changelog

:cl: del: Beluga-class, Box-class, Schmiedeberg-class, Colossus-class, Skipper-class and Kansatsu-class lost their Ore Redemption Machines. /:cl:

Sadhorizon avatar Jul 22 '24 18:07 Sadhorizon

This needs to come after improvements to the UI and usability of furnace setups

thgvr avatar Jul 22 '24 23:07 thgvr

This needs to come after improvements to the UI and usability of furnace setups

Those ships shouldn't have furnaces/ORMs in the first place. The only reason they do is because they are old.

Sadhorizon avatar Jul 22 '24 23:07 Sadhorizon

The outpost one also sucks to use.

thgvr avatar Jul 22 '24 23:07 thgvr

This needs to come after improvements to the UI and usability of furnace setups

This is only removing ORMs from ships that shouldn’t have had them to begin with. Existing mining specialists keep their current equipment.

The outpost one also sucks to use.

That the outpost furnace sucks to use isn’t really relevant to the fact that a hospital ship shouldn’t have its own refining machine, for example- if the issue’s bad enough, just put an ORM on the outpost and call it a day until furnaces get touched up.

Apogee-dev avatar Jul 23 '24 08:07 Apogee-dev

I would like to clarify something. No map should have an ORM. Some maps get a smeltery like on the outpost or the Delta. Please remove it from all ships if you are doing an orm removal.

The only reason I didn't suggest replacing it on the mining ships that still have one is because that usually necessitates at least a partial remap. But if we're going for a hard removal, then yeah, some minor remapping on the Gecko and Hyena will be necessary. They'll get more polished remaps in the next month or two anyway.

Apogee-dev avatar Jul 25 '24 02:07 Apogee-dev

I would like to clarify something. No map should have an ORM. Some maps get a smeltery like on the outpost or the Delta. Please remove it from all ships if you are doing an orm removal.

Point of the PR is to remove ore smelting from non-mining/salvage ships. Not really interested in remapping gecko and hyena rn, I'm sure they will be handled at some point.

Also, I've been told not to touch aspawn ships, if that's what you mean. Though I can, if you want me to.

Sadhorizon avatar Jul 25 '24 12:07 Sadhorizon

This PR has been inactive for a month. This means it is at risk of being auto closed in a week, please address any outstanding review items and ensure your PR is finished, if these are all true and you are auto-staled anyway, you need to actively ask maintainers if your PR will be merged. Once you have done any of the previous actions then you should request a maintainer remove the stale label on your PR, to reset the stale timer. If you feel no maintainer will respond in that time, you may wish to close this PR youself, while you seek maintainer comment, as you will then be able to reopen the PR yourself

github-actions[bot] avatar Aug 25 '24 01:08 github-actions[bot]

@Sadhorizon do you think you could remake this sometime?

rye-rice avatar Oct 25 '24 03:10 rye-rice

I guess?

Sadhorizon avatar Oct 25 '24 04:10 Sadhorizon

This pull request has conflicts, please resolve those before we can evaluate the pull request.

github-actions[bot] avatar Oct 25 '24 04:10 github-actions[bot]

im releasing this from purgatory

thgvr avatar Nov 03 '24 10:11 thgvr