Shiptest icon indicating copy to clipboard operation
Shiptest copied to clipboard

TEG efficiency code tweaks.

Open Thera-Pissed opened this issue 1 year ago • 1 comments

About The Pull Request

Code is from citadel this PR in particular Tweaks TEG code to have efficiency dependent on temperature delta, instead of whatever the hell whitesands was doing. This also results in there no longer being an upper cap on TEG output. Go for a highscore. image desmos graph if you want to play with numbers: Y\ =\frac{0.45}{1+\left(e^{-0.0009\cdot\left(X\ -\ 10000\right)\ }\right)}

Why It's Good For The Game

more thermodynamically good is better! makes room for more accurate and balanced TEGs also tmtmtl said this was a good and easy first step towards better TEGs.

Changelog

:cl: code: TEG efficiency now depends on temperature delta. /:cl:

Thera-Pissed avatar Jul 18 '24 12:07 Thera-Pissed

yup, this is exactly what i was looking for. i'm pretty sure the PR that made this change at first was also based off of that PR and just misinterpreted it horribly?

tmtmtl30 avatar Jul 19 '24 22:07 tmtmtl30

This PR has been inactive for a month. This means it is at risk of being auto closed in a week, please address any outstanding review items and ensure your PR is finished, if these are all true and you are auto-staled anyway, you need to actively ask maintainers if your PR will be merged. Once you have done any of the previous actions then you should request a maintainer remove the stale label on your PR, to reset the stale timer. If you feel no maintainer will respond in that time, you may wish to close this PR youself, while you seek maintainer comment, as you will then be able to reopen the PR yourself

github-actions[bot] avatar Aug 21 '24 00:08 github-actions[bot]