Shiptest icon indicating copy to clipboard operation
Shiptest copied to clipboard

Angle grinder AGAIN! Also, makes plasma cutters used for salvage instead of mining (and base gearpacks)

Open Thera-Pissed opened this issue 1 year ago • 13 comments

About The Pull Request

re-implements #1716 as a base and adds cutter functionality to plasma cutters also implements and uses gear packs from #2103 that never got in. makes plasma cutters unable to mine, shorter range, and do burn instead of brute. angle grinders are integrated into grinder packs, like water backtanks. Also draws power from a cell. jackhammers can no longer break down walls and girders.

Cutters can currently deconstruct:

  • girders
  • walls
  • reinforced walls
  • airlocks
  • airlock frames
  • grilles
  • machine frames
  • computer frames
  • catwalks
  • chairs
  • beds
  • tables
  • lockers & crates
  • salvage machines (the wasteplanet ones)
  • railings
  • lattice
  • wooden barricades

cutters can also cut open safes and locked lockers & crates

attempted to revert map changes but using git checkout doesn't completely revert the gecko. Will try again later.

adds a mech salvage saw and a prototype energy saw. Doesn't make either available yet.

sprites by me image

https://github.com/shiptest-ss13/Shiptest/assets/90987989/12262338-055f-4c7c-86d1-d31279ab953c

Why It's Good For The Game

Jackhammers as a main salvage tool is dumb, and angle grinders and cutters make more sense and have better functionality. Cutting apart old ruins and ships should be a reasonable source of material and shouldn't take years.

Changelog

:cl: add: angle grinders for salvage add: reworks plasma cutters for salvage /:cl:

Thera-Pissed avatar Jun 23 '24 23:06 Thera-Pissed

very rad

Martinpachu avatar Jun 24 '24 01:06 Martinpachu

Can you remove breaching functionality from jackhammers, since there's now a specialty tool for that job? I never really liked the thing with jackhammers battering down metal walls anyway.

Apogee-dev avatar Jun 28 '24 20:06 Apogee-dev

Can you remove breaching functionality from jackhammers, since there's now a specialty tool for that job? I never really liked the

should replace them on the colossus and any other ships in that case

Martinpachu avatar Jun 28 '24 20:06 Martinpachu

any other ships that use them for breaching i mean. i dont think any are using them for mining though.

Martinpachu avatar Jun 28 '24 20:06 Martinpachu

I'll remove the jackhammer effect, though angle packs are cheap enough that I don't want to touch maps just yet. Which ships would need their jackhammers replaced, though?

Thera-Pissed avatar Jun 28 '24 20:06 Thera-Pissed

I'll remove the jackhammer effect, though angle packs are cheap enough that I don't want to touch maps just yet. Which ships would need their jackhammers replaced, though?

colossus, hound (if you even care.....) gecko, hyena, inkwell and chronicle.

Martinpachu avatar Jun 28 '24 20:06 Martinpachu

This pull request has conflicts, please resolve those before we can evaluate the pull request.

github-actions[bot] avatar Jun 29 '24 07:06 github-actions[bot]

couple maps tweaked to have roundstart cutters and packs

Thera-Pissed avatar Jun 29 '24 07:06 Thera-Pissed

This pull request has conflicts, please resolve those before we can evaluate the pull request.

github-actions[bot] avatar Jul 05 '24 05:07 github-actions[bot]

the mudskipper has a surgical saw in a "salvage supplies" crate iirc which i'm pretty confident is meant to represent an angle grinder

JimKil3 avatar Jul 07 '24 02:07 JimKil3

This pull request has conflicts, please resolve those before we can evaluate the pull request.

github-actions[bot] avatar Jul 12 '24 04:07 github-actions[bot]

This pull request has conflicts, please resolve those before we can evaluate the pull request.

github-actions[bot] avatar Jul 30 '24 22:07 github-actions[bot]

waiting for #3145 to be merged before I continue working on this, since it overlaps a decent amount.

Thera-Pissed avatar Jul 31 '24 21:07 Thera-Pissed

This PR has been inactive for a month. This means it is at risk of being auto closed in a week, please address any outstanding review items and ensure your PR is finished, if these are all true and you are auto-staled anyway, you need to actively ask maintainers if your PR will be merged. Once you have done any of the previous actions then you should request a maintainer remove the stale label on your PR, to reset the stale timer. If you feel no maintainer will respond in that time, you may wish to close this PR youself, while you seek maintainer comment, as you will then be able to reopen the PR yourself

github-actions[bot] avatar Aug 31 '24 00:08 github-actions[bot]

couple oddball things I want to work on but Im happy with the basic grinder and plasma cutter changes. not sure about plasma cutters in toolbelts from the destructible walls pr, but I'll wait and see how it goes.

Thera-Pissed avatar Sep 16 '24 23:09 Thera-Pissed

This pull request has conflicts, please resolve those before we can evaluate the pull request.

github-actions[bot] avatar Sep 23 '24 17:09 github-actions[bot]

This pull request has conflicts, please resolve those before we can evaluate the pull request.

github-actions[bot] avatar Sep 25 '24 14:09 github-actions[bot]