tether icon indicating copy to clipboard operation
tether copied to clipboard

Dead links in the readme

Open jkeen opened this issue 4 years ago • 20 comments

The readme links to https://github.hubspot.com/tether/ for documentation, and those links are dead.

Not sure if you're managing http://tether.io/ now, but that site is loading weird too.

jkeen avatar Feb 25 '20 18:02 jkeen

Definitely need to fix these. Not entirely sure how though.

RobbieTheWagner avatar Feb 26 '20 20:02 RobbieTheWagner

Not sure if you're managing http://tether.io/ now, but that site is loading weird too.

It looks OK from here. A network blip, perhaps?

TrevorBurnham avatar Feb 26 '20 21:02 TrevorBurnham

@TrevorBurnham it's fully broken with a lot of 404. I think github.hubspot.com was perhaps removed?

RobbieTheWagner avatar Feb 26 '20 23:02 RobbieTheWagner

😕 Weird, https://github.hubspot.com/ loads just fine for me too…

TrevorBurnham avatar Feb 26 '20 23:02 TrevorBurnham

@TrevorBurnham hmm, I think we mean https://github.hubspot.com/tether/ specifically.

RobbieTheWagner avatar Feb 27 '20 00:02 RobbieTheWagner

Looks like you already solved it: 69fa6af

TrevorBurnham avatar Feb 27 '20 00:02 TrevorBurnham

@TrevorBurnham no, not solved yet. No idea how to solve all the 404s from http://tether.io/

There are a bunch of resources that are set to github.hubspot.com still and I don't know where those are coming from.

Screen Shot 2020-02-26 at 8 41 34 PM

RobbieTheWagner avatar Feb 27 '20 01:02 RobbieTheWagner

There are a bunch of resources that are set to github.hubspot.com still and I don't know where those are coming from.

That domain is hard-coded into the Jade templates on the gh-pages branch, which all the HTML files are built from: https://github.com/shipshapecode/tether/blob/76e57602e477072a659024feb781211edf62396f/resources/templates/base.jade#L18-L34

TrevorBurnham avatar Feb 27 '20 01:02 TrevorBurnham

Ah thanks @TrevorBurnham! I did not realize those templates existed. That fixed the 404 issue, but now I think we're just hitting a lot of issues with Tether changes. Will try to fix it all soon.

RobbieTheWagner avatar Feb 27 '20 05:02 RobbieTheWagner

@rwwagner90 it's still broken :thinking:

Desan avatar Aug 26 '20 14:08 Desan

@Desan yeah, haven't been able to figure out how to fix it

RobbieTheWagner avatar Aug 26 '20 15:08 RobbieTheWagner

@TrevorBurnham any idea how hsdoc works? I keep trying to edit templates and building overwrites my changes.

RobbieTheWagner avatar Dec 17 '20 14:12 RobbieTheWagner

@rwwagner90 Hmm… sorry, it's a mystery to me too!

TrevorBurnham avatar Dec 17 '20 16:12 TrevorBurnham

@TrevorBurnham any idea who we could ask?

RobbieTheWagner avatar Dec 17 '20 16:12 RobbieTheWagner

^ @zackbloom @adamschwartz Does this bring back memories for you? 😄

TrevorBurnham avatar Dec 17 '20 17:12 TrevorBurnham

A trip down memory lane! hsdoc, as you can imagine, is a build tool on top of (I think?) grunt. Can we just change the domain in the built files like little cheaters, or do we need the build to work?

zackbloom avatar Dec 17 '20 19:12 zackbloom

@zackbloom the hsdoc command seems to blow away all my changes every time. I'm trying to update base.jade but if I delete these two lines, they just come back when I run hsdoc -a https://github.com/shipshapecode/tether/blob/gh-pages/resources/templates/base.jade#L45-L46

I guess rather than using the jade templates we have defined here, hsdoc somehow has a default template setup that adds these things back again? I would like to be able to edit the jade templates without them being overwritten every time.

RobbieTheWagner avatar Dec 17 '20 19:12 RobbieTheWagner

I wish I knew the answer, but I don't even have a copy of the hsdoc source anymore. The smart thing would probably be to port it to a more modern build chain, but I can't say how much work that would be.

zackbloom avatar Dec 18 '20 13:12 zackbloom

Looks like tether.io maybe expired and got swooped up by the Tether crytocurrency project. It now redirects to tether.to.

tilgovi avatar Apr 13 '22 19:04 tilgovi

We just moved to https://tetherjs.dev/

RobbieTheWagner avatar Apr 20 '22 17:04 RobbieTheWagner