vessel icon indicating copy to clipboard operation
vessel copied to clipboard

PHP 8 Support

Open jkque opened this issue 3 years ago • 6 comments

Description

Not a bug but just asking if you will support php 8 thanks @fideloper

jkque avatar Nov 27 '20 09:11 jkque

Yep, will be working on that soon enough!

fideloper avatar Nov 27 '20 12:11 fideloper

thanks @fideloper 🎉🎉🎉

jkque avatar Nov 27 '20 12:11 jkque

@fideloper thanks for such a nice little utility, I am wondering if php 8 support has been added yet?

aftab-rfg avatar Oct 04 '21 22:10 aftab-rfg

Hi!

Since Laravel Sail exists, you may want to use that instead.

That being said, Yeah I can likely get php8 working here without too much hassle.

Let me know if you try out Sail tho!

On Mon, Oct 4, 2021 at 5:18 PM aftab-rfg @.***> wrote:

@fideloper https://github.com/fideloper thanks for such a nice little utility, I am wondering if php 8 support has been added yet?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/shipping-docker/vessel/issues/148#issuecomment-933898931, or unsubscribe https://github.com/notifications/unsubscribe-auth/AADSDU5BZU6YTDKZSJYYAETUFIR23ANCNFSM4UEUWLPQ . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

fideloper avatar Oct 04 '21 22:10 fideloper

I already tried Laravel sail, but I thought vessel was a bit more flexible and can easily be customised. If that's not the case then I will revert back to that :-)

Thanks

aftab-rfg avatar Oct 04 '21 22:10 aftab-rfg

@fideloper the php version can be manage by a ENV variable.. this containerized solution is pretty great and server many other things apart of larashit!

there are some ways:

  • by a sed substitution of "7.4" string and "FROM" by example we set PHP_VER=8 (php 8.1) then the vessel can sed the "FROM" and change from FROM ubuntu:20.04 (that ships 7.4 php) to FROM ubuntu:22.04 (that ships 8.1 php) or PHP_VER=L that sed to FROM ubuntu:24.04 (soon to be releasesd).. **this measn that even use php7.4-pgsql php7.4-sqlite3 in package names you can also use php-pgsql php-sqlite that exists and defauts internally to such respective versions
  • by a specific Dokerfile files for each version and use softlyns .. the PHP_VER=8 internally in the vessel will just link the respective dockerfile that provide the respective php version.. by example if we have PHP_VER=8 , the vessel must have docker/app/Dockerfile-php8 and then just softlink (ln -s) docker/app/Dockerfile-php8->docker/app/Dockerfile

we can just pass or configure the php version as PHP_VER=8 for php 8.1, PHP_VER=7 for php 7.4 or PHP_VER=L for 8.2 (winbuntu lasted, cos i gues you will use LTS only) and use respective winbuntu image in the docker-files/docker/app/Dockerfile

mckaygerhard avatar Sep 02 '23 15:09 mckaygerhard