Shoukaku icon indicating copy to clipboard operation
Shoukaku copied to clipboard

Add lavalink state (useful for resuming system)

Open flav-code opened this issue 2 years ago • 9 comments

flav-code avatar Jun 10 '22 02:06 flav-code

Typings are not correctly specified, check github actions for info

Deivu avatar Jun 11 '22 03:06 Deivu

Any benefit of this?

KagChi avatar Jun 12 '22 02:06 KagChi

allows to know if the bot has been disconnected during a restart

flav-code avatar Jun 12 '22 02:06 flav-code

I dont get what you mean, this pr seems useless

KagChi avatar Jun 12 '22 02:06 KagChi

if you don't have a system to resume the players then it will be useless for you

flav-code avatar Jun 12 '22 02:06 flav-code

No i mean, this is not used internally by shoukaku it self. why dont you just extend the player instead?

KagChi avatar Jun 12 '22 02:06 KagChi

because it could be useful for other people and it doesn't impact the good functioning of shoukaku

flav-code avatar Jun 12 '22 02:06 flav-code

Instead of playerState, I'd call it connected, and do not make it type boolean|nulll instead make it only a boolean type that defaults to false until LL sends the first playerUpdate to this player. playerState = true is unclear on what it provides / says

Deivu avatar Jun 12 '22 03:06 Deivu

Could also be our own type, eg: type state = Connected | Disconnected | Unknown

Deivu avatar Jun 12 '22 03:06 Deivu

Closing due to inactivity, re-open if you applied the changes I said above

Deivu avatar Sep 10 '22 02:09 Deivu