wobserver icon indicating copy to clipboard operation
wobserver copied to clipboard

Allow credentials to be passed up to allow securing behind phoenix pipelines

Open mgwidmann opened this issue 6 years ago • 6 comments

The following does not work:

scope "/admin" do
  pipe_through :admin

  forward "/wobserver", Wobserver.Web.Router
end

All JSON api requests end up being denied because no cookies are sent and so therefore cannot be validated.

mgwidmann avatar Sep 20 '17 18:09 mgwidmann

Coverage Status

Coverage remained the same at 99.716% when pulling 5d69ac62da8ffd2cb9c7d6672a163c38a78744f9 on mgwidmann:include_credentials into 7c6186ba8a90d9406d2b79351081373a52baffdf on shinyscorpion:master.

coveralls avatar Sep 20 '17 18:09 coveralls

I'm not sure that my changes actually caused those errors, did they?

mgwidmann avatar Sep 20 '17 19:09 mgwidmann

bump any thoughts on this? Its quite annoying to build this from source every time...

mgwidmann avatar Oct 02 '17 13:10 mgwidmann

can we get some movement on this PR?

mgwidmann avatar Nov 23 '17 02:11 mgwidmann

looking at master, the build was already broken, so it wasn't you @mgwidmann.

langalex avatar Jan 05 '18 12:01 langalex

most of the breakage occurred with this "Update dependencies." commit

langalex avatar Jan 05 '18 12:01 langalex