Sébastien Hinderer
Sébastien Hinderer
The commit entitled "Use `target` instead of `host` when relevant in configuration" looks okay to me, modulo two mundane questions: 1. I stumbled over the beginning of the commit message:...
The commit entitled "Detect a _build_ C toolchain to build `sak`" is okay except for one thing. Could you please move the definitions of the `SAK_` variables from `Makefile.config.in` to...
Small suggestions about the commit entitled "Check that the OCaml versions are compatible for a cross compiler", which is in itself a very good idea. 1. Nit: couldn't the `cross_compiler=true`...
One suggestion and one question about the commit that adds `Makefile.cross`: Suggestion: you do: ``` crossopt: $(MAKE) runtime-all ``` This can be simplified to: ``` crossopt: runtime-all ``` which is...
And, still about the `Makefile.cross` commit (sorry, comment posted too promptly): I did not quite understand why `HOST_ZSTD_FLAGS` is not handled in `configure`?
Just a stylistic question about your "Enable bootstrapping flexdll in the cross-compiler setting" commit: In the previous commit that creates `Makefile.cross`, put the target first and then onlythe varialbes, in...
Regarding your "Add cross-compilation cases to `sak`" commit: In the commit message, you write `When building an OCaml cross-compiler Windows to Unix`. I think this should be either `When building...
Thank you, @shym. It's a pleasure to collaborate with you.
Cool! Thanks a lot, @nojb!!
Hello, Apologies for being so silent, the circumstances do not seem to be aligned fo regular contributions to the compiler, sadly. I very much think ocamldep and the compiler itslef...