Jonathan Shimwell
Jonathan Shimwell
This feature was recently added to cadquery :tada: so we can refactor the stl export a bit https://github.com/CadQuery/cadquery/commit/03c3266b8d61d487349a15f73d3b3cb13bce625f
Looks like the docs are building again, but they appear to have lost thier + signs for expanding the menus plus signs not there when using these versions - sphinx...
We have lots of tests that have a nested function def and then assert the function call raises an error, for example https://github.com/fusion-energy/paramak/blob/8862e29f3761d06dac5fd368160c26face82b900/tests/tests_units/test_shape.py#L64-L76 however this test could be shortened to...
spotted this error in the CI ```python def test_volume_increases_with_rotation_angle(): test_shape_1 = paramak.DishedVacuumVessel(rotation_angle=180) test_shape_2 = paramak.DishedVacuumVessel(rotation_angle=360) > assert test_shape_1.volume() * 2 == pytest.approx(test_shape_2.volume()) E assert 0.0 == 21536838.298035033 ± 2.2e+01 E...
Pytest has a nice way of skiping tests https://docs.pytest.org/en/7.1.x/reference/reference.html#pytest-importorskip We could use this to skip tests that require optional dependencies
Some particle lost tracking issues were reported when trying to make a dagmc model from a Paramak Reactor class that contained thin volumes. Example is here for me to look...
The export stl function loops through the volumes in reactor.solid and saves each volume to an stl file. However there is a nice option to first merge the surfaces then...
OpenMC is the default code for the DAGMC export function but it can be useful to support other codes. DAGMC geometry tags are slightly different in openmc we can use...
## Proposed changes Adding a new shape which is a circular extrusion with a rounded top