bun
bun copied to clipboard
shime
Add to Bundler?
Hi! Would you perhaps be interested in adding these abilities to Bundler itself? We've recently started working on it, with the add command, but it seems like a waste to duplicate your work. Thanks!
Hey André! I didn't know about the add command when I was making this gem. I would love to add this functionality to Bundler itself!
What abilities do you want to see added? I don't see anything for removing gems from the Gemfile and I like how my gem handles adding to groups.
@shime That's great to hear. My thoughts are to incorporate the whole functionality into bundler, if that's ok with you, because there's no need to duplicate efforts and your CLI UX is awesome.
For removing gems, I think bundle remove is a good start but will need team consensus. For adding to groups, yours is shorter, but unfortunately here's where bundler will probably have to stay with it's CLI convention because of backward compatibility and keeping a convention for future proofing.
To get started: One option is to first agree on the bundler cli commands conventions... so compare your commands of adding and removing gems to bundler's with the options and suggest the bundler equivalent commands with options for it. This might be best done through an RFC in this repo so bundler team members can chime in. Once the commands are agreed then it's straightforward to implement it. Here's an example of bundler's add RFC.
Alternative options is to build it, create PR, and iterate based on feedback.
Lastly, I recommend you join the bundler slack group should you have quick questions.
Hey @indirect and @shime I would love to work on adding Bun capabilities into Bundler for Google summer of code 2020. Whether i get picked or not, this is a challenge i am willing to take on.
Hi @katungi. There was work previously done to integrate most, if not all, of the Bun capabilities into bundler. See the following PR's: https://github.com/rubygems/bundler/pull/6513 https://github.com/rubygems/bundler/pull/6547 https://github.com/rubygems/bundler/pull/6556
If you see something that is not integrated and would like to work on that, then feel free to propose an idea as your GSoC project.