Michael Shilman

Results 773 comments of Michael Shilman

I think @domyen wanted to redesign..

@virtuoushub Can you share how to reproduce this? I tried adding your example above to a simple CRA project and it worked as expected (the test failed with the same...

What do you think about just making the test name the story name per #70 So rather than: ```js describe('MyComponent', () => { describe('Story1', () => { it('play-test', () =>...

AFAIK the maxWorkers determines how many pages get created. these pages get reused throughout the lifetime of the test run, unless there is a failing test. at that point, the...

Hmm can confirm that it opens a new browser for each story file. @yannbf this sounds like a bug to me. WDYT?

@RobertHaslinger The test runner requires 6.4 and above. You can upgrade with: ``` npx sb upgrade ```

The problem is that the test runner actually analyzes the AST of CSF files. Adding svelte support will just bloat the test runner and is not feasible. It's a similar...

My bad @IanVS -- indeed we don't generate `stories.json` for svelte stories, so for now the test runner doesn't work with svelte. 😢 I don't see us adding support to...

Solution in progress here https://github.com/storybookjs/addon-svelte-csf/issues/65

Son of a gun!! I just released https://github.com/storybookjs/storybook/releases/tag/v6.4.0-alpha.25 containing PR #15742 that references this issue. Upgrade today to the `@next` NPM tag to try it out! ``` npx sb upgrade...