shiki icon indicating copy to clipboard operation
shiki copied to clipboard

Usage Missing instructions on setCDN

Open alamhubb opened this issue 2 years ago • 2 comments

Consider adding a note about setCDN to Usage?

Otherwise, it will bring great trouble to users. The following problems are related to the lack of setCDN related content in the document

If you add setCDN related documents to Usage, it may reduce your troubles

https://github.com/shikijs/shiki/issues/216 https://github.com/shikijs/shiki/issues/246 https://github.com/shikijs/shiki/issues/346

no work

image

work ok

image

alamhubb avatar Aug 28 '22 11:08 alamhubb

I think this might need a separate code sample, because this would be worse on node (which I think is the majority of usage) and this is only useful for browsers environments - open to PRs

orta avatar Aug 29 '22 10:08 orta

I think this might need a separate code sample, because this would be worse on node (which I think is the majority of usage) and this is only useful for browsers environments - open to PRs

You can add this line of code and comment when you need this line of code and when you don't

like

//when useful for browsers environments
setCDN(xxx)

alamhubb avatar Aug 30 '22 04:08 alamhubb