Women-in-Technology icon indicating copy to clipboard operation
Women-in-Technology copied to clipboard

Adding events description to readme and event/program page

Open Jayita10 opened this issue 2 years ago • 13 comments

Fixes #130

Type of change

Checklist:

  • [ ] My contribution follows the style guidelines of this project
  • [ ] I have performed a self-review of my own contribution
  • [ ] I have made corresponding changes to the documentation
  • [ ] My changes generate no new warnings
  • [ ] I have checked my code and corrected any misspellings

Jayita10 avatar Oct 05 '21 06:10 Jayita10

For adding description in event page, do I need to modify eventlist.js?

Jayita10 avatar Oct 05 '21 07:10 Jayita10

For adding description in event page, do I need to modify eventlist.js?

Modify eventlist.js and modify the cards in event.js

nehakalbande avatar Oct 05 '21 10:10 nehakalbande

For adding description in event page, do I need to modify eventlist.js?

Yes, pull the repo, because some changes have been made and add the description in the cards

shikha-16 avatar Oct 06 '21 06:10 shikha-16

did you put the descriptions? is this ready to merge? @Jayita10

shikha-16 avatar Oct 10 '21 18:10 shikha-16

did you put the descriptions? is this ready to merge? @Jayita10

Please wait for 2 more days! I am little busy with college work, Thanks!

Jayita10 avatar Oct 11 '21 04:10 Jayita10

did you put the descriptions? is this ready to merge? @Jayita10

Please wait for 2 more days! I am little busy with college work, Thanks!

okay no problem, lmk when its ready to merge!

shikha-16 avatar Oct 11 '21 05:10 shikha-16

https://github.com/shikha-16/Women-in-Technology/blob/6c0cdb18d60723f837e5a8e4b8cca328e992d1c7/website/src/pages/events.js#L43

<Typography paragraph variant="h5" component="h2">
           {a.description}
</Typography>

Here I am thinking of using paragraph , Will it be okay? Actually I haven't much knowledge on meterial ui and typography, so asking for conformation!

@shikha-16

Jayita10 avatar Oct 12 '21 05:10 Jayita10

https://github.com/shikha-16/Women-in-Technology/blob/6c0cdb18d60723f837e5a8e4b8cca328e992d1c7/website/src/pages/events.js#L43

<Typography paragraph variant="h5" component="h2">
           {a.description}
</Typography>

Here I am thinking of using paragraph , Will it be okay? Actually I haven't much knowledge on meterial ui and typography, so asking for conformation!

@shikha-16

Hi @Jayita10 Please have a look at Material UI Components, since there components are responsive and looks good. With p tag you'll need to more css.

nehakalbande avatar Oct 12 '21 05:10 nehakalbande

@Jayita10 whats the status on this?

shikha-16 avatar Oct 15 '21 07:10 shikha-16

Please review @shikha-16 @nehakalbande

Jayita10 avatar Oct 17 '21 13:10 Jayita10

Okay @Jayita10 can u attach a screenshot of how it looks on the website?

shikha-16 avatar Oct 19 '21 09:10 shikha-16

Okay @Jayita10 can u attach a screenshot of how it looks on the website?

@Jayita10

shikha-16 avatar Oct 21 '21 19:10 shikha-16

hi @Jayita10 can you please respond as soon as possible. thanks

shikha-16 avatar Oct 27 '21 07:10 shikha-16