Women-in-Technology
Women-in-Technology copied to clipboard
shikha-16
Adding events description to readme and event/program page
Fixes #130
Type of change
Checklist:
- [ ] My contribution follows the style guidelines of this project
- [ ] I have performed a self-review of my own contribution
- [ ] I have made corresponding changes to the documentation
- [ ] My changes generate no new warnings
- [ ] I have checked my code and corrected any misspellings
For adding description in event page, do I need to modify eventlist.js?
Modify eventlist.js and modify the cards in event.js
For adding description in event page, do I need to modify eventlist.js?
Yes, pull the repo, because some changes have been made and add the description in the cards
did you put the descriptions? is this ready to merge? @Jayita10
Please wait for 2 more days! I am little busy with college work, Thanks!
did you put the descriptions? is this ready to merge? @Jayita10
Please wait for 2 more days! I am little busy with college work, Thanks!
okay no problem, lmk when its ready to merge!
https://github.com/shikha-16/Women-in-Technology/blob/6c0cdb18d60723f837e5a8e4b8cca328e992d1c7/website/src/pages/events.js#L43
<Typography paragraph variant="h5" component="h2">
{a.description}
</Typography>
Here I am thinking of using paragraph , Will it be okay?
Actually I haven't much knowledge on meterial ui and typography, so asking for conformation!
@shikha-16
https://github.com/shikha-16/Women-in-Technology/blob/6c0cdb18d60723f837e5a8e4b8cca328e992d1c7/website/src/pages/events.js#L43
<Typography paragraph variant="h5" component="h2"> {a.description} </Typography>Here I am thinking of using
paragraph, Will it be okay? Actually I haven't much knowledge on meterial ui and typography, so asking for conformation!@shikha-16
Hi @Jayita10 Please have a look at Material UI Components, since there components are responsive and looks good. With p tag you'll need to more css.
Okay @Jayita10 can u attach a screenshot of how it looks on the website?
@Jayita10