jekyll-category-archive-plugin icon indicating copy to clipboard operation
jekyll-category-archive-plugin copied to clipboard

plugin doesn't work with pagination

Open natelandau opened this issue 10 years ago • 14 comments

Shigeya

thanks for this plugin. it was working perfectly until i turned on pagination in my jekyll 1.4.2 site. Adding any pagination numeral to _config.ym, say, paginaion:5 immediately causes an error on building the site. Generating... error: no implicit conversion of nil into String. Removing your plugin makes this error disappear.

I am far from a programmer and I'm at a loss.

Thanks for making your amazing plugin available

natelandau avatar Jan 04 '14 03:01 natelandau

Hi. Let me look into the problem. I haven't used pagination in my sites so haven't realized this.

shigeya avatar Jan 04 '14 08:01 shigeya

+1 for pagination.

mhulse avatar Jan 05 '14 23:01 mhulse

OK. It must be easy to fix but I don't have spar time to work on this till weekend. Let me work on this in this weekend.

shigeya avatar Jan 06 '14 01:01 shigeya

Not sure if it will help you, but I just found this:

https://github.com/ilyakhokhryakov/jekyll-tagging-pagination

... for tags, but it's pretty easy to modify for categories too.

Thanks for sharing your code @shigeya!!!!! :+1:

mhulse avatar Jan 06 '14 08:01 mhulse

Hi. I guess that it looks like this is not this plugin's problem. Could you try run jekyll with --trace flag, provide the output? you can post to gist.github.com and paste the link here. Note that in my environment adding paginate: 5 do not cause error. Also, I assume you're configuring paginate not pagination in _config.yaml (ref: http://jekyllrb.com/docs/pagination/)

shigeya avatar Jan 12 '14 13:01 shigeya

Oh yah? Nice! Personally, I saw this issue and assumed pagination didn't work. Thanks for testing @shigeya!

mhulse avatar Jan 13 '14 06:01 mhulse

I'm seeing the same issue with paginate set in Jekyll 1.4.2.

gpxl avatar Jan 14 '14 18:01 gpxl

@gpxl @mhulse As I said, I can't reproduce here. So, please provide stack trace, by running jekyll with --trace option and provide the trace as gist. I'm willing to help. If the trace is not large, you can directly paste here too. thanks.

shigeya avatar Jan 15 '14 01:01 shigeya

Here's a gist with the output I'm seeing as well as the _config.yml file I'm using. Not sure how much it will help since it doesn't trace back to the plugin directly. I ended up rolling my own plugin, but I'm up to test a fix if you need.

https://gist.github.com/gpxl/8430738

gpxl avatar Jan 15 '14 04:01 gpxl

Thanks. hmm. Right, it looks like the exception is not directly related to my plugin...

shigeya avatar Jan 15 '14 04:01 shigeya

The error arises only when your plugin is in use. With it enabled and paginate set in config.yml, I get this error: Generating... error: no implicit conversion of nil into String. Use --trace to view backtrace

Disabling pagination or the plugin both resolve the error. Here's the stacktrace.

greyshi avatar Feb 11 '14 04:02 greyshi

Thanks. Let me look into this, but please don't expect answer soon. (I'm really busy at this moment..)

shigeya avatar Feb 12 '14 02:02 shigeya

I have the same problem when I use another plugin jekyll-monthly-archive-plugin with jekyll 1.4.2. When I change jekyll to version 1.2.0,the error "Generating... error: no implicit conversion of nil into String. " disappears.

minixalpha avatar Feb 14 '14 15:02 minixalpha

Ah, @minixalpha, thanks. Good point. I haven't stated about the version I'm using. I'm using 1.4 and later, and only tested against 1.4 series.

shigeya avatar Feb 15 '14 02:02 shigeya