shiftkey
system menu should be visible when in full-screen mode
Describe the bug
Once used toggle full view (F11), it can not switch back. I tried Ctrl+0, Esc, F11 again. When pressed Ctrl+= or Ctrl+- and later Ctrl+0 the view come back to standard size lettering, but still full view. I can not access the menu toolbar. After closing and opening the program stays still full view. I had a previous release (2.4.1) and installed a new one (2.5.0), still full view. When running from terminal, this is a message.
zivile@zivile-linux-kompas:~$ github-desktop [12884:0524/150540.050421:ERROR:buffer_manager.cc(488)] [.DisplayCompositor]GL ERROR :GL_INVALID_OPERATION : glBufferData: <- error from previous GL command
Version & OS
- GitHub Desktop Version: 2.5.0-linux1
- Operating system Ubuntu 18.04.4 LTS
Steps to reproduce the behavior
- Go to ' GUI GitHub Desktop.'
- Click on ' View - toggle full view (F11).'
Expected behavior
to be able to toggle back, to normal, diminished view
@Zivilevs thanks for the report! I've not been able to reproduce this on 20.04 LTS - I can press F11 to return to the normal view, and other keyboard shortcuts like zoom in and out continue to work.
The only bit of weirdness I've uncovered is that the system menu is no longer visible when you're in fullscreen, so if you didn't know the keyboard shortcut and were hoping to find the menu item again you'd be stuck. I don't believe this is related to the bug, but is likely related to when we reverted the in-app menu bar in #237.
Any extra details to help reproduce the issue on my end? Anything interesting in the console when you run View | Toggle developer tools?
@shiftkey I've checked the console, but I do not see anything out of common. After I've toggled to full screen view I am just stuck there without the system menu. Untill I upgrade to Ubuntu 20.04, I'll make do with the keyboard shortcuts. Thank you for your time.
After I've toggled to full screen view I am just stuck there without the system menu.
I'm also seeing this issue, so let's leave this open to see if we can improve this area at all so the menu is still available when in fullscreen.