Brendan Forster

Results 633 comments of Brendan Forster

@OiYouYeahYou that's some great information - thanks for sharing! For reference we're using the inbuilt Electron updater APIs - based on [Squirrel.Windows](https://github.com/Squirrel/Squirrel.Windows) - but I'm sure there's room for improvement...

> It'll be also nice to download only updated files, not the complete package. @HackcatDev the framework we use in Electron on Windows, [`Squirrel.Windows`](https://github.com/Squirrel/Squirrel.Windows/), supports delta packages to apply just...

@robbie-thompson thanks for the feedback! Which version of the app are you running?

@ggrrll as mentioned in #3624, I think there's a corner case here that's tricky to fix: https://github.com/desktop/desktop/blob/be2712877593641de83b7104da6569e113a2f033/app/test/unit/git/checkout-test.ts#L112 This test tries to checkout a remote branch where it has the same...

Could you attach the full log files? The **Help** | **Show Logs in Explorer** menu items should open the logs folder, and inside those are the log files generated by...

Yeah, there's repetitions of the same error in here: ``` 2018-04-25T12:43:38.725Z - error: [ui] `git -c credential.helper= checkout --progress overleaf/master -b master --` exited with an unexpected code: 128. fatal:...

> A potential solution for this would be to, in cases where an existing local branch exists and will clash, use the convention `{remote}-{branch}` when the user wants to checkout...

Adding `user-research` to this label as we got a few 👍 to my suggestion above from a few months ago but unclear on next steps.

@danilaml would the solution I talked about here https://github.com/desktop/desktop/issues/4527#issuecomment-386221312 help address this limitation?

I'll also point out that we're tracking an upstream Git limitation about how to correctly handle remote branch names containing `/` - #3618 - which is why I recommended using...