Brendan Forster

Results 633 comments of Brendan Forster

Punting this to 0.8 because I'm really not in the mood for more Powershell right now

> Probably not as it would mean one user could affect another without admin privileges and that would be bad. That's what I suspect. Any and all evidence to the...

@stefanolson I'm seeing some failing tests with the IAppSetup bits. Let me investigate as it's probably something that's come in as part of the renaming of things.

@stefanolson could you also have a look in the Squirrel logs to see if (as I suspect) there's a ReflectionTypeLoadException like this: ``` [WARN][2013-12-03T12:43:17] InstallerHookOperations: Couldn't load types from module...

Oooh, I know this one! https://github.com/Squirrel/Squirrel.Windows/blob/master/src/Squirrel.Client/InstallerHookOperations.cs#L176 We only scan `*.exe` - which is a decision made way back in the day. As we really want people to not have `IAppSetup`...

@stefanolson great! I'll leave this open as a reminder to - add support for `.dll` files - possibly look to deprecate support for `.exe` files in the future

> 1. You specify an invalid url (borked URI) > 2. The folder containing updates does not exist Catching those errors and surfacing them as `ShimmerConfigurationExceptions` (and updating the sample...

Oops, I'm not thinking of something I planned to do, but something I'd already shipped: https://github.com/github/Shimmer/commit/d450bacbe37331b96466769952b4c310401a871f Ok, so coming back to your code above - there's two things we could...

So I added a test like this: ``` [Fact] public void WhenFolderDoesNotExistThrowHelpfulErrorAsync() { string tempDir; using (Utility.WithTempDirectory(out tempDir)) { var directory = Path.Combine(tempDir, "missing-folder"); var fixture = new UpdateManager(directory, "MyAppName",...