vi

Results 111 comments of vi

> We should probably error if both delete_message_days and clean_history_duration are provided at the same time. https://github.com/DisnakeDev/disnake/pull/659/commits/976c3ca00ef43465fecdd1185deb48c9e858cfb8

This unfortunately breaks cases where `.response.edit_message` is used with a new view, since the new view gets added to the store with the message ID (known, since it's a component...

Oh, and when using `.edit_message(view=self)` instead, it results in the view being added a second time to the store, one with the interaction ID in the key (from original `.send`),...

https://github.com/discord/discord-api-docs/pull/5186

> Not exactly sure which error handler this should redirect to, eg should an on_error be dispatched, Dispatching on_error is difficult since we'd need to await it, blocking further gateway...

> I ended up causing an issue where parse_message_create event could not deseralise the message. This would cause every single message to cause an exception, and by default I don't...

> > Although possibly a new event could be warranted, `on_critical_error` where: This event is dispatched for errors originating outside of the control of the library. > > That _might_...

> I still don't see a toggle :P @onerandomusername [check again](https://github.com/DisnakeDev/disnake/pull/401/commits/31a05133391e4ccb3ea2cc9799f7a5fbd8ae6f48) c: This PR should now be ready again, pretty sure I incorporated all suggestions.