API-Security-Checklist icon indicating copy to clipboard operation
API-Security-Checklist copied to clipboard

Add Monitoring section to the list

Open msfidelis opened this issue 6 years ago • 4 comments

Add Monitoring session.

msfidelis avatar Jul 13 '17 11:07 msfidelis

@netcode Aside from the points raised by the reviewers above (all good points worth addressing!), any thoughts about this PR? Should we accept (pending the corrections mentioned above) or just close this, or were we waiting for something else (more discussion, etc)?

Maikuolan avatar Aug 14 '17 16:08 Maikuolan

It does add value, so I'd be inclined to accept/merge the PR; additional changes/tweaks can always be merged in via another PR.

kenguest avatar Aug 15 '17 18:08 kenguest

Done. Thanks for help!

msfidelis avatar Aug 15 '17 18:08 msfidelis

I've pushed the suggested changes to this PR just now. Any further thoughts on this from anyone?

Maikuolan avatar Jul 24 '22 07:07 Maikuolan

(My apologies if multiple review requests suddenly appeared/disappeared. Something went wrong with my browser or the UI here, not sure which, and new requests didn't appear in pending reviewers for bit, so wasn't sure whether it went through or not).

Maikuolan avatar Nov 06 '22 05:11 Maikuolan

I mean this was 5 years ago haha I have no idea what this even is anymore 😂 but sure, looks okay

othyn avatar Nov 09 '22 10:11 othyn

Thank you. '^.^

I'll merge now.

Maikuolan avatar Nov 09 '22 11:11 Maikuolan