keyvault-acmebot icon indicating copy to clipboard operation
keyvault-acmebot copied to clipboard

Published 20 hours ago • verified publisher icon shibayan

Fixes #493 - Unit tests for DomeneShop provider

Open eloekset opened this issue 2 years ago • 3 comments

A test project using XUnit and Moq to verify the functionality of all public methods of the DomeneShop provider. Sample data for three domains is included as json files, and all values are dummy values, but still exactly like the v0 of DomeneShop API.

Helped me verify and fix a bug in this provider.

eloekset avatar Jul 03 '22 21:07 eloekset

I can rebase on master if you want to merge #491 before this one.

eloekset avatar Jul 03 '22 21:07 eloekset

I believe that the correctness of the DNS Provider can only be verified by running the actual DNS API. I don't see the value in testing code using a mock API.

shibayan avatar Jul 04 '22 06:07 shibayan

I use sample messages copied from the request and response messages in Postman. image

It helps, by letting me debug the code and verify the functionality of the provider before deploying the application.

eloekset avatar Jul 04 '22 15:07 eloekset

In my opinion mocking the DNS provider API is pointless and doesn't change the fact that you need to hit the actual API. This PR will not be merged.

shibayan avatar Dec 22 '22 17:12 shibayan