keyvault-acmebot icon indicating copy to clipboard operation
keyvault-acmebot copied to clipboard

Published 20 hours ago • verified publisher icon shibayan

Fixes #491 - Add support for DomeneShop

Open eloekset opened this issue 2 years ago • 9 comments

An attempt at implementing support for https://domene.shop.

I haven't even tested it once, so don't merge this until it's tested. How can I deploy a PR to my own environment to test it?

eloekset avatar Jun 26 '22 14:06 eloekset

I've tested and verified that this provider now works fine.

image

image

eloekset avatar Jun 29 '22 21:06 eloekset

For some reason I'm not able to create a PR for the wiki, but this is the documentation related to this provider:

Domeneshop

App settings

  • Acmebot:DomeneShop:ApiKeyUser
    • API user from the token column at domene.shop
  • Acmebot:DomeneShop:ApiKeyPassword
    • API password from the secret column at domene.shop

Example API Token configuration

Navigate to https://domene.shop/admin?view=api

image

eloekset avatar Jun 29 '22 21:06 eloekset

I suspect a bug when trying to delete a TXT record. I made another commit to this branch, which is not merged into this PR yet: https://github.com/shibayan/keyvault-acmebot/commit/3bd785a2192f29890b32b06fa8735110411a8377

Are you able to confirm how this works @shibayan? I think we should try to refactor the providers to be able to write unit tests for some sample domains and sample inputs to the public methods. That would make it much easier to contribute with additional providers.

eloekset avatar Jun 30 '22 20:06 eloekset

The bug has been fixed and verified with unit tests.

eloekset avatar Jul 03 '22 21:07 eloekset

Acmebot's DNS Provider implementation handles relative record names correctly, so I am not aware of any defects. It is left to the individual DNS Provider implementation.

shibayan avatar Jul 04 '22 06:07 shibayan

The bug is fixed now in this commit and verified with unit tests.

I started off copying the CustomDnsProvider. For some reason the DomeneShopProvider shouldn't combine the relativeRecordName with the DnsZone.Name like the CustomDnsProvider does. image

I guess it depends on the implementation of the DNS provider's API whether or not the DnsZone.Name should be included.

eloekset avatar Jul 04 '22 15:07 eloekset

It is a CustomDnsProvider-specific specification, not a bug in Acmebot's implementation; different DNS Providers require different information, so they pass neutral values.

shibayan avatar Jul 10 '22 04:07 shibayan

What is the status on this? Any hope of having this merged into the main branch? @shibayan

josteinkirkebak avatar Jun 20 '23 13:06 josteinkirkebak

What is the status on this? Any hope of having this merged into the main branch? @shibayan

You can use my fork if you need support for Domeneshop and/or Namecheap 😃

eloekset avatar Jun 20 '23 16:06 eloekset