Komondor icon indicating copy to clipboard operation
Komondor copied to clipboard

Fix Future Package Conflicts

Open leogdion opened this issue 2 years ago • 5 comments

If someone is using Rocket there's a potential for conflicts in the future:

'komondor': warning: 'komondor' dependency on 'https://github.com/f-meloni/Rocket' conflicts with dependency on 'https://github.com/shibapm/Rocket' which has the same identity 'rocket'. this will be escalated to an error in future versions of SwiftPM.

This fixes that issue in the future.

leogdion avatar May 09 '22 13:05 leogdion

@minuscorp could you look at this when you get a chance?

leogdion avatar Jun 23 '22 19:06 leogdion

The question is, is really rocket needed for this package? Its configuration is empty, so it's no making anything right?

minuscorp avatar Jun 23 '22 19:06 minuscorp

It's supposed to be used when tagging to remove dev dependencies. It's a dev dependency similar to how SwiftFormat is utilized.

leogdion avatar Jun 23 '22 20:06 leogdion

This was/is always a constraint in SPM's resolving systems - it's possible that SPM doesn't force downloading of things which aren't referenced by now?

orta avatar Jun 24 '22 09:06 orta

Right which is why Rocket exists essentially. I'm sure that's the purpose of swift package plugins. Regardless this will break in future versions of Swift if the dependencies aren't consistent.

leogdion avatar Jun 24 '22 13:06 leogdion

Any updates?

417-72KI avatar Mar 02 '23 14:03 417-72KI

We should merge this, as it is correct anyway

orta avatar Mar 02 '23 19:03 orta