eslint-plugin-typescript-enum icon indicating copy to clipboard operation
eslint-plugin-typescript-enum copied to clipboard

Support TypeScript 5.2.2

Open dominicfraser opened this issue 2 years ago • 3 comments

Context

TypeScript 5.2.2 comes with a breaking change that requires all @typescript-eslint/* dependencies to move to >= v6: https://github.com/typescript-eslint/typescript-eslint/issues/7155#issuecomment-1692384149.

In this repository that specifically means moving from

"@typescript-eslint/experimental-utils": "^5.3.0"

to

"@typescript-eslint/utils": "^6.0.0"

Changes

Add tests

To give more confidence that behaviour was preserved before and after making changes tests have been added.

This was done using the recommendations from https://typescript-eslint.io/developers/custom-rules#testing - use @typescript-eslint/rule-tester paired with vitest.

These tests can be reverted if they are not desired.

Update to @typescript-eslint/utils and [email protected]

This is the main change, allowing this really helpful plugin to continue to be used with newer typescript.

dominicfraser avatar Sep 18 '23 21:09 dominicfraser

This is a breaking change as well for this package I guess, might need to bump the major version~

shian15810 avatar Dec 15 '24 13:12 shian15810

I'm thinking should I merge your PR and release a major version first before bumping @typescript-eslint/utils to v8 in another PR. This way people stuck with v6 of @typescript-eslint/utils could make use of your changes in this PR.

@dominicfraser What do you think?

shian15810 avatar Dec 15 '24 14:12 shian15810

Hi @shian15810 ☺️

I tested updating to v8, and pushed a commit showing what that would look like: https://github.com/shian15810/eslint-plugin-typescript-enum/pull/338/commits/34496c58dd7c75bf6243333122da57784961b0fc.

I've then reset it back to v6.

I think your plan of merging with the v6 changes, doing a release, and then updating to v8 and doing another release is a good plan. It gives flexibility to people to be able to update in stages if they need to 👍

dominicfraser avatar Dec 20 '24 13:12 dominicfraser