shuhung
shuhung
> bremner commented Mar 12, 2024 via email: > Is there a corresponding commit in the main racket repo? Probably not worth deep investigation, but I could well have used...
In BSL/BSL+, I think printing functions are mostly impossible, so only ISL/ISL+ are within the scope. Currently ISL prints things as `function:XYZ` (https://github.com/racket/htdp/commit/8a6d34936606). In ISL+, should functions like `add`, `posn-x`,...
> @rfindler wrote: > Right now the criteria is a bit wonky, using the current namespace. That strikes me as unlikely to be the best criteria (although it may have...
Some tests are added to `module-lang-test.rkt` @ https://github.com/racket/drracket/pull/689/commits/046311b3bcf75830c9a95d17a90845bfe0c517f0 in https://github.com/racket/drracket/pull/689.
> @rfindler wrote: > Another approach would be to simply (or conditionally) remove [this test](https://github.com/racket/pconvert/blob/master/pconvert-lib/mzlib/pconvert.rkt#L319-L325). So: rather than setting the namespace, directly matching lambda's name against the pattern `#px"[.]rkt:\\d+:\\d+"` in...
> I'm a little bit suspicious of using a regular expression on the name. There might be a better way: can you clarify a little bit why just using object-name...
Updated with a new solution. As it seems, enable `use-function-output-syntax` plus some small changes fix the issue. No need to change pconvert-lib or touch the namespace. The tests are available...
Oops, it is still not fixed for unnamed lambdas in files. The tests do not save buffers to files so they did not capture the bug.
@mikesperber this PR is ready. Do you see any obvious issues with turning on the `use-function-output-syntax` option, ~~or with the regexps I used in the `use-named/undefined-handler` guard~~? @rfindler The code...
Done! Removing source locations solves the problem.