libspf2 icon indicating copy to clipboard operation
libspf2 copied to clipboard

don't use the SPF RRTYPE

Open bdijkstra82 opened this issue 8 years ago • 3 comments

RFC 7208 deprecates the use of the SPF RRTYPE (99). Some DNS servers refuse to respond to any request with this type, libspf2 errors out in this case. This commit removes all use of ns_t_spf.

bdijkstra82 avatar Mar 24 '16 16:03 bdijkstra82

The pr currently deletes config.h.in and has a massive difference in configure. Those seem extraneous and should be removed.

kitterma avatar Mar 25 '16 04:03 kitterma

I wasn't sure what do to with these two files as they appear to be generated files. I deleted them to signal that they should be re-generated. If the pr will be rejected because of this, please let me know.

bdijkstra82 avatar Mar 25 '16 08:03 bdijkstra82

While this change is good, debian (se below) did only one line. If use a custom build of 1.2.11 in production you must have this patched applied. Maybe this smaller patch may be merged for 1.2.12.

--- a/src/libspf2/spf_server.c 2012-01-28 09:24:47.000000000 +0100
+++ b/src/libspf2/spf_server.c 2014-06-19 14:09:07.000000000 +0200
@@ -346,7 +346,7 @@
 						spf_response, spf_recordp);

 	/* I am VERY, VERY sorry about the gotos. Shevek. */
-	rr_type = ns_t_spf;
+	rr_type = ns_t_txt;
 retry:
 	rr_txt = SPF_dns_lookup(resolver, domain, rr_type, TRUE);
 

eriklax avatar Oct 04 '23 18:10 eriklax