shesha-framework
shesha-framework copied to clipboard
Modal Buttons display despite settings
Description
When utilizing the Modal dialog box Entity Reference type, the modal buttons persistently display even when the Show Modal Buttons option is set to false. Similarly, the modal buttons continue to appear when Allow New Record is enabled on the Entity picker.
Steps to reproduce the behavior:
- Navigate to 'https://function-adminportal-test.shesha.dev/dynamic/Boxfusion.SheshaFunctionalTests.Common/book-twenty-two'
- Click on 'Add'
- Open form designer mode.
- Drag and drop an Entity Picker component and configure it.
- Enable the Allow New Record option.
- Ensure that Show Modal Buttons is set to false.
- Save and render the form.
- Click on the Entity Picker and select the Add New button.
- Observe that the modal buttons persist despite the Show Modal Buttons setting.
- Similarly, within the details form, add a new Entity Reference and select the modal box dialog entity type.
- Do not select the Show Modal Buttons option.
- Save and render the form.
- Observe that the modal buttons still display.
Expected behavior
When Show Modal Buttons are set to false or when Allow New Record is enabled without the modal buttons option selected, the modal buttons should not appear in the Entity Picker or Entity Reference modal dialog.
Hi @James-Baloyi , I see your PR has been merged, however not everything from the card is completed. The work item mentioned two components experiencing the same issue and your change only applied to one component
I'm consulting with a developer on ways we can pass the newly created item to the entity picker when using a custom button. A separate card will be created to accommodate that