spark-wallet icon indicating copy to clipboard operation
spark-wallet copied to clipboard

rpc: pass "params" keyword dictionary to clightning

Open SimonVrouwe opened this issue 2 years ago • 0 comments

Together with https://github.com/shesek/lightning-client-js/pull/4 this passes "params" {key: val, ...} dictionary directly to c-lightning. So we can use keywords instead of exactly ordered (and obligatory null) positional args.

A "params" [ val, val2,... ] array with positional args is still accepted, so I think clients can migrate slowly.

Hope this doesn't break anything, a basic regtest with existing Spark-client v0.3.2-rc (on emulator) showed no issues. Inspired while trying to fix the Spark/Sparko backend of Zeus wallet.

edit: Spark's custom rpc methods, _listinvoices, _listpays etc. still require positional args to be passes as array.

SimonVrouwe avatar Dec 06 '22 12:12 SimonVrouwe