shescoding
added social-share-button gem
Added social share gem so that individual resources can be shared accordingly. For this update, the share buttons that are enabled are "twitter facebook google_plus google_bookmark tumblr".
Two comments:
- The gem version 0.1.9 is not available anymore, so this throws an error when attempting bundle install. I have used the latest version instead, 0.2.1, and that one works.
- Can you add LinkedIn and Email to share from? And I would remove the Google Bookmark option - 2 Google share options are a bit confusing. I would also remove Tumblr, and just keep the 'main' ones: Twitter, Facebook, LinkedIn, Google+ and Email. And potentially Pinterest, once the bug you mentioned on Trello is fixed. Considering we're using a new version of the gem here, maybe the Pinterest integration works now?
Hey @probinson2015 , did you still want to look at those comments I made and update this branch? It would be nice to get those buttons in :) Otherwise I can take care of doing those updates as well. Just let me know? Thanks!
Hi @natsteinmetz this has been updated. Pinterest still requires a thumbnail in order to share on their site. Would you like to use one of our She's Coding thumbnails, maybe space cat? The only problem I can think of is the gem doesn't currently allow of a way to provide a special url parameter that is only to be used for a specific button. Could probably figure out a way to make it work though with a little jQuery but would still need to know which image to use. This is an issue only for Pinterest sharing. Thanks!
@probinson2015 Thanks for the ping! 😃This looks good and works as expected - I was wondering though: could you make the icons a tidbit bigger, and spread them out a bit? There's enough space on their right side to give them a bit of breathing room.
Let me know if you'd prefer this to be opened as separate issue, that'd be no problem.
Hi Nathalie, I've updated this per your request. I thought any more spread out and it's a bit jarring to the eye as it's quite a colorful pattern and it's repeated on every tile. Let me know what you think. I can update accordingly. Thank you!