node-uber icon indicating copy to clipboard operation
node-uber copied to clipboard

Replace geocoder 0.2.2 with node-geocoder latest

Open lc-101 opened this issue 6 years ago • 1 comments

It seems this lib is using geocoder version 0.2.2. Unfortunately when google started requiring users to use an API key for their geocoder API, all functions in the lib that relayed on geocoder stopped working. I do see #24 where it seems node-geocoder was going to be added to the project, looking at the commit history I only ever see geocoder as being part of the project. It seems that we would need to replace geocoder with node-geocoder and add methods to pass API keys to the lib.

Thoughts?

lc-101 avatar Jan 11 '19 19:01 lc-101

@lc-101 Created PR but I have issues with test on my env. Looks like its working :) https://github.com/shernshiou/node-uber/pull/74

dorshay6 avatar Apr 28 '19 21:04 dorshay6