sherlock icon indicating copy to clipboard operation
sherlock copied to clipboard

DockerHub image is not getting updated

Open mxschmitt opened this issue 4 years ago • 5 comments

The current one which is referenced in the README was last updated 2 years ago: https://hub.docker.com/r/theyahya/sherlock

Similar to #221

Action item: The DockerHub integration (see here for docs) needs to be updated so that automatic builds work. Maybe move it to a sherlock-project namespace on DockerHub?

mxschmitt avatar Mar 11 '21 11:03 mxschmitt

Using Github Actions to build and push these images would solve this problem. Something like this should work flawlessly.

If the devs like the idea, I'll gladly make a pr.

xescure avatar Mar 29 '21 19:03 xescure

~~Docker Hub provides an automated solution to build and push the image on their infrastructure, then there is no manual effort needed. Of course it's also implementable via GitHub Actions, but seems easier via the Docker Hub.~~

mxschmitt avatar Mar 29 '21 22:03 mxschmitt

As far as I'm aware DockerHub doesn't natively support armhf and arm64 images which are getting more and more important in the era of Raspberry Pis and M1 Macs. If we bother with fixing this whole thing, we might as well do it right.

xescure avatar Mar 30 '21 09:03 xescure

Good catch! Yeah then your approach would be the better one, I remember also things about that.

mxschmitt avatar Mar 30 '21 09:03 mxschmitt

Hi @mxschmitt!

Thank you for letting me know about this issue. Unfortunately I have no experience with Docker but the maintainer of the Docker image is @TheYahya, so maybe he may be able to help out.

sdushantha avatar Jun 27 '21 10:06 sdushantha