sherlock-project
Fix(sites): Remove unreliable Lush Stories site check
This pull request resolves an issue where the site check for Lush Stories was producing false positives for non-existent usernames.
Problem: The site redirects both valid and invalid profile URLs to a login page for unauthenticated users. This made it impossible for Sherlock to distinguish between a found and not-found profile, causing any username check to be reported as a success.
Solution:
After attempting several detection methods (status_code, response_url), it was determined that a reliable check is not possible without being logged in.
To improve the overall accuracy of the tool and prevent future false positives, this commit completely removes the Lush Stories site from data.json.
This fixes the issue reported by the user in the initial problem description.
Automatic validation of changes
| Target | F+ Check | F- Check |
|---|---|---|
| CyberDefenders | :heavy_check_mark: Pass | :heavy_check_mark: Pass |
| SlideShare | :x: Fail | :heavy_check_mark: Pass |
| Lush Stories | :heavy_check_mark: Pass | :heavy_check_mark: Pass |
| threads | :x: Fail | :heavy_check_mark: Pass |
| Roblox | :x: Fail | :heavy_check_mark: Pass |
Failures were detected on at least one updated target. Commits containing accuracy failures will often not be merged (unless a rationale is provided, such as false negatives due to regional differences).
![github-actions[bot] avatar](https://avatars.githubusercontent.com/in/15368?v=4 "Published by a pub.dev verified publisher"){kind=small}
Automatic validation of changes
| Target | F+ Check | F- Check |
|---|---|---|
| Lush Stories | :heavy_check_mark: Pass | :heavy_check_mark: Pass |
| CyberDefenders | :x: Fail | :heavy_check_mark: Pass |
| threads | :x: Fail | :heavy_check_mark: Pass |
| Roblox | :x: Fail | :heavy_check_mark: Pass |
| SlideShare | :x: Fail | :heavy_check_mark: Pass |
Failures were detected on at least one updated target. Commits containing accuracy failures will often not be merged (unless a rationale is provided, such as false negatives due to regional differences).
Your PR desc mentions the removal of this site, but the diff simply modifies the site in-place
Which change was intended here?
Automatic validation of changes
| Target | F+ Check | F- Check |
|---|---|---|
| threads | :x: Fail | :heavy_check_mark: Pass |
| CyberDefenders | :heavy_check_mark: Pass | :heavy_check_mark: Pass |
| Roblox | :x: Fail | :heavy_check_mark: Pass |
| SlideShare | :x: Fail | :heavy_check_mark: Pass |
Failures were detected on at least one updated target. Commits containing accuracy failures will often not be merged (unless a rationale is provided, such as false negatives due to regional differences).
@ppfeister You were right! I had committed the modification instead of the full removal. Please check now