sherlock icon indicating copy to clipboard operation
sherlock copied to clipboard
verified publisher icon sherlock-project

fixed speedrun site support #2288

Open Suramyavns opened this issue 1 year ago • 6 comments

Suramyavns avatar Sep 10 '24 08:09 Suramyavns

This PR seems to duplicate Speedrun, and with two different detection methods. Safe to say that this is unintentional?

PS - The addition of username_unclaimed is going to make this fail schema validation.

ppfeister avatar Sep 10 '24 20:09 ppfeister

I removed the duplication of speedrun and fixed the error checking in the existing site data for speedrun

Suramyavns avatar Sep 11 '24 02:09 Suramyavns

hey @ppfeister this is one of my first FOSS contributions I just wanted to know if my PR would be merged soon

Suramyavns avatar Sep 12 '24 10:09 Suramyavns

Busy week is all. Schema wise it's good now, I've just gotta validate the check when I have a moment. Won't be long though as long as it checks out :+1:

ppfeister avatar Sep 12 '24 20:09 ppfeister

Busy week is all. Schema wise it's good now, I've just gotta validate the check when I have a moment. Won't be long though as long as it checks out 👍

hey merge it now maybe?

Suramyavns avatar Oct 02 '24 16:10 Suramyavns

@ppfeister please merge it now

YuvamGupta avatar Oct 14 '24 09:10 YuvamGupta