sched icon indicating copy to clipboard operation
sched copied to clipboard

Published 20 hours ago • verified publisher icon sherifabdlnaby

NewJobWithID needed?

Open Fishwaldo opened this issue 3 years ago • 1 comments

Just seems redundant as the Only Caller is NewJob?

https://github.com/sherifabdlnaby/sched/blob/6eeb2cc626e821489a11ee8219b239ced2f900a2/job/job.go#L32

Fishwaldo avatar Apr 21 '21 03:04 Fishwaldo

Yes, it was there so that maybe this sub package would be imported in an external project as a standalone package. But actually i am considering making the Job package not exported all together so we don’t have to maintain its backward compatibility.

sherifabdlnaby avatar Apr 21 '21 04:04 sherifabdlnaby