Jake Goulding

Results 615 comments of Jake Goulding

I pulled down your repo and it appeared to work well with the changes I made, so I'll go ahead and merge. Thanks!

> snafu::Backtrace page says it is enabled by default, It does not say that; it actually says (emphasis mine) > Backtrace functionality is **currently** enabled. “Currently” does not mean “default“....

It's worth pointing out that [we enable non-default features on docs.rs](https://github.com/shepmaster/snafu/blob/0.6.3/Cargo.toml#L23-L25)

This feels like a very niche requirement, so I'm not super inclined to support it in SNAFU directly. However, my gut tells me that there's some better solution available. You...

That certainly seems like an avenue worth pursuing! Sometimes the compiler errors arising from conditional implementations are hard to decipher though.

> ```rust > ensure!(1 < 0, Error::OOMError); > ``` You are running into the number one problem with SNAFU — crossing the context selectors and the enum variants. This line...

Oh, you _are_ using 0.7 — that's good! Please let me know how I can improve [the documentation](https://docs.rs/snafu/0.7.0-beta.2/snafu/index.html) to help avoid this problem as this specific problem is a major...

> can we apply this multiple times to a given entry This was an idea that I had in mind when implementing it. You are right that it's not currently...

> I think it'd be worth having a separate issue for supporting multiple `source(from)` attributes. Agreed. I mostly didn't do it originally to avoid YAGNI; was hoping that if someone...

> using multiple concrete types instead of a trait bound. I wonder if those ideas could be unified? Some unification would be cool, but I haven't seen how yet.