Jake Goulding
Jake Goulding
> Hmm, for signed it can't short-circuit what should `u8::MAX + 2 - 1` yield?
One complaint I’ve heard about `FromStr` is that the result cannot reference the input. That is, you can’t do `&'a str -> MyType
Hey, this is wonderful, thank you! All of the code changes look fine and I'd be happy to merge them. That being said... > It looks like jetscii is somewhat...
Hmm, CI is indicating that these *can't* be const yet, as the closure may need to be dropped. To my knowledge, there's no way of specifying that we only want...
Ok, I think I have sorted out CI. I merged my branch and yours and added a [little tweak](https://github.com/shepmaster/jetscii/commit/ab03777ee859dc983db1a4ba7f0e9ef99cbb2c0c) to set the target, as you had it. That combined CI...
Thanks @BurntSushi, that is an awesome writeup! I'll try to respond to points that caught my eye or I think I can be useful on... > find_big_16_early_return The differences of...
@Dr-Emann What do you see as our next steps forward?
Awesome, thanks for this! I'm certainly not surprised that there are pathological cases, but having them pointed out in test cases is even nicer. One thing I assume will help...
> 9 MB/s Ouch. Lots to fix!
One thought is that the `pcmpestrm` instruction should be able to tell which byte fails strcmp, which I believe can be used to stride further.