Jake Goulding

Results 616 comments of Jake Goulding

> the actual message of what went wrong ("unable to turn pointer into raw bytes") I think that this should be reported separately as an upstream Rust bug.

Seems reasonable; could you add a test to ui/frontend/selectors/index.spec.ts? You happen to be the first PR after I reworked CI a bit, and I see I've broken it for people...

Quick thoughts: - *running* rustdoc isn't hard by itself, although we'd have to pre-build all the docs for the provided crates like we pre-compile them. - *displaying* the rendered docs...

> linking to the already hosted documentation I haven't actually used this; is there a way to get it to point to docs.rs? > send those to the frontend over...

When you asked for the Docker version on the official server, I realized that you don't have access to the current setup. It's different from what's documented in the README...

Now that I've had a chance to read through, I'm thinking we might be able to do this: 1. Reuse the existing build and upload to S3 phases. 1. Add...

> [compiling to musl] can probably be removed. To be clear, I don't think we should do that during this PR; I'd rather have fewer moving parts.

> See this [playground](https://play.rust-lang.org/?version=stable&mode=debug&edition=2021&gist=4dd892c16ea886953a346081829d3b9f). Looks fine: It appears you need to provide more information about what editor / editor settings you are using.

https://microsoft.github.io/monaco-editor/ reproduces the problem: You'll need to [file an issue with them](https://github.com/microsoft/monaco-editor). Looks like [the Rust config](https://github.com/microsoft/monaco-editor/blob/ab869e8469cd1cda70d25bb454732f84b523098c/src/basic-languages/rust/rust.ts#L112-L113) has both `int` and `uint`. Presumably this is from some very old code...

This is already present earlier in the compilation message: ![image](https://user-images.githubusercontent.com/174509/97124848-2bfb5180-1708-11eb-90e0-fa93b3cbddf0.png) I'd accept a PR to apply the same logic to the `--explain` line. It would be good to test it...