shepherd icon indicating copy to clipboard operation
shepherd copied to clipboard

classPrefix breaks target blocking

Open npedrini opened this issue 4 years ago • 8 comments

If you specify a classPrefix in the tour options, any highlighted elements in steps where canClickTarget = true are still clickable because the following css selector breaks:

.shepherd-target-click-disabled.shepherd-enabled.shepherd-target,.shepherd-target-click-disabled.shepherd-enabled.shepherd-target *{
    pointer-events:none
}

The following custom css rule has to be added, taking into account the classPrefix:

.shepherd-target-click-disabled.walkthrough-shepherd-enabled.shepherd-target,.shepherd-target-click-disabled.walkthrough-shepherd-enabled.shepherd-target *{
    pointer-events:none
}

npedrini avatar Jan 15 '21 09:01 npedrini

@npedrini would you like to submit a PR adding class prefix support for this?

RobbieTheWagner avatar Jan 15 '21 13:01 RobbieTheWagner

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

stale[bot] avatar Feb 27 '21 22:02 stale[bot]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

stale[bot] avatar Jun 09 '21 22:06 stale[bot]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

stale[bot] avatar Jul 13 '21 01:07 stale[bot]

Is this issue still happening ? can I take it ?

edenriquez avatar Oct 08 '21 05:10 edenriquez

@edenriquez sure thing, please feel free to take it!

RobbieTheWagner avatar Oct 09 '21 12:10 RobbieTheWagner