ha-dyson-cloud
ha-dyson-cloud copied to clipboard
shenxn
Bump libdyson to 0.8.11
Confirming this fixes the loading failure described at https://github.com/shenxn/ha-dyson/issues/138. It'd be great to get this merged for that reason alone.
@shenxn this is causing the entire integration to not work due to failed dependencies. Merging this provides a simple fix.
Hey @shenxn we really appreciate your work on this, but it looks like life has got you busy. Would you be interested in assigning project collaborators to help get PRs merged?
It's been a while since the last message. For the sake of getting a working integration available for people, I think it might be time to raise the idea of forking and setting up collaborators. Without the solo maintainer to unblock these PRs, there's really no other way to get moving and avoid months-long blocks like this in the future.
I'm not entirely sure what the correct etiquette here is, and I'm also worried about fragmenting the ecosystem. Any internet search for "Dyson fan in Home Assistant" currently leads here - trying to funnel users somewhere else will inevitably sow confusion, so I'd really like for @shenxn to consider just adding collaborators instead.
This currently isn’t a default HACS, nor core HA, integration so I guess strictly speaking anyone could fork it and submit for inclusion in HACS.
Yeah, I think that's gonna have to be the way things go. It will disrupt anyone who needs to update to support new Formaldehyde models, the HP07 refresh of the HP04, etc. They won't be able to auto-update to the fork, and will likely need to reconfigure the new integration with their automations and dashboards. Not a great experience for users, but better than nothing.
At least since this and the ha-dyson repo aren't default in HACS, we can expect most current users to already be aware of this repo and know how to use Github. Failing a proper readme update, we can still at least post a "Working fork is over here -->" issue for people to follow.
For the time being, as long as it's not stepping on anyone's toes, I'll merge and test the commits from all these PRs into my forks of the following repos:
- https://github.com/shenxn/libdyson
- https://github.com/shenxn/ha-dyson
- https://github.com/shenxn/ha-dyson-cloud (the repo this current PR is on)
Thanks - that works I think. I also feel like the domain value is what sets each integration apart. So long as that stays the same I think peoples integrations should be able to seamlessly update.
Actually looks like someone else has done it: https://github.com/nf-homeauto
I'll see if I can get in touch with @natefanaro and see if he wants to be the new core maintainer.
My fork was an attempt to add the Humidify+Cool Formaldehyde. I gave up after a while and haven't tried again yet. Not sure I want to be a core maintainer. Happy to share my code if I get mine working.
@natefanaro thanks for clarifying! I just wanted to make sure I wasn’t stepping on your toes, especially since I saw you had already gone as far as to republish libdyson on pypi and create a corresponding organization on Github.
I’ll go ahead and continue with my merges tomorrow then!