HongShen comments

Results 13 comments of


                                            HongShen

[CALCITE-3298] Add getSelectivity for TableScan in RelMdSelectivity

Checks is failed because: ` [00:20:59] [ERROR] Tests run: 29, Failures: 0, Errors: 28, Skipped: 1, Time elapsed: 3.999 s

[CALCITE-3298] Add getSelectivity for TableScan in RelMdSelectivity

Who can help to review this patch?

[CALCITE-3298] Add getSelectivity for TableScan in RelMdSelectivity

@hsyuan Done.

[CALCITE-3298] Add getSelectivity for TableScan in RelMdSelectivity

@julianhyde Done

[window] Optimization aggregation window by segment tree

> @shenh062326 Curious if this is based on https://www.vldb.org/pvldb/vol8/p1058-leis.pdf paper and similar to https://duckdb.org/2021/10/13/windowing.html Yes, the optimization idea is base on it. > CI is red. Would you take a...

[window] Optimization aggregation window by segment tree

> * Please can you write a small design doc for SegmentTree describing the structure and the functions you have written. Add a design doc for SegmentTree: https://docs.google.com/document/d/126MIwwKJA_557_UUDy3QRqbO79ta0veTLZgKGObwRFo/edit > *...

[window] Optimization aggregation window by segment tree

@aditi-pandit Can you take a look at this PR.

[window] Optimization aggregation window by segment tree

> Thanks @shenh062326 for working on this. > > Please can you give me permissions to comment on this doc. Done. > > I still feel it will be better...

[window] Optimization aggregation window by segment tree

1. Rebase main to fix conflict. 2. Separate SegmentTree into its own class. 3. Remove config min_frame_size_use_segment_tree and add kMinFrameSizeUseSegmentTree.

Optimize operator's performance when vector has low selectivity

It seems better to accumulate the output of operator instead of input, since the operators are lesser. Is there a detail development plan? I can help if need.