Shen Tian

Results 48 comments of Shen Tian

Looking at [this line](https://github.com/andrewmcveigh/cljs-time/blob/c6c304745ea9f9b0201f295ca97d1532e6ee1f4b/src/cljs_time/format.cljs#L284) in `format.cljs`. `unparse-duration` converts a period to milliseconds first, then to the duration string. However, you can only do this for periods of less than a...

So, what the right behaviour then? `clj-time` doesn't have an `unparse-duration`. We have: (time-format/unparse-duration (time/map->Period {:days 1})) => "1 day" what should (time-format/unparse-duration (time/map->Period {:years 1})) => ?? feels like...

Bumped into #44. Merging this would be really helpful.

It's been a while, but worth an update. This particular behaviour has caused quite a few bugs in our system in the last few month. We are dealing with it...

In PR #19 , I changed the parsing code for `set-user` to read like this: ```clojure :email (let [provider-data (.-providerData firebase-user)] (when-not (empty? provider-data) (-> provider-data first .-email)))})) ``` which...

Sounds like this is a more general question of what to do with the (lossy) conversion of clojure data structures to JSON and back again. This does the conversion back:...

Sounds like it's a question of what meaning can we give to an anchor link to the page your are already on? Is it always a no-op, or same as...

Do you know what [accountant](https://github.com/venantius/accountant) does, by any chance?