Andrew Powell

Results 568 comments of Andrew Powell

Likely related to https://github.com/tonyganch/gonzales-pe/issues/114, and should note that it parses fine in 3.0.0-31, but not 3.2.1.

Managed to trace the problem to the trailing ampersand: `input[type=button]&,`. Haven't managed to trace the source of gonzales to find out why, however.

@tonyganch I'm getting the same thing. why does that occur? ``` → node > var g = require('gonzales-pe'); undefined > console.log(g.cssToAST('@2x: none;')) Error: Please check the validity of the CSS...

https://github.com/tonyganch/gonzales-pe/pull/128 may fix this as well

A functioning example can be seeing on lesscss.org here: http://lesscss.org/less-preview/#%7B%22less%22%3A%22.browser-prefix(%40prop%2C%20%40args)%20%7B%5Cn%20%20-webkit-%40%7Bprop%7D%3A%20%40args%3B%5Cn%20%20-moz-%40%7Bprop%7D%3A%20%40args%3B%5Cn%20%20-ms-%40%7Bprop%7D%3A%20%40args%3B%5Cn%20%20-o-%40%7Bprop%7D%3A%20%40args%3B%5Cn%20%20%40%7Bprop%7D%3A%20%40args%3B%5Cn%7D%5Cn%5Cn.foo%20%7B%5Cn%20.browser-prefix('bar'%2C%20'baz')%3B%20%5Cn%7D%22%7D

That's all I needed at the moment. The code allows for expansion if we modify errors to contain anything other than line and syntax. It's just forward-thinking.

sure thing! here's the output from lessc for a parse error: ``` → lessc --lint /src/icons.less ParseError: Unrecognised input. Possibly missing opening '{' in /Users/.../src/icons.less on line 14, column 1:...

Great, thanks for considering it!

@ded issue is an old one and running into this on IE8,9.

This rule https://eslint.org/docs/rules/no-param-reassign exists for the same reason. It's considered bad practice, with a few exceptions, to modify incoming variables. If that's something you didn't understand or know, would it...