shellhub-io
[Enhancement] Increase ssh window size
I've personally found the terminal window to be a bit too small when there's a lot of terminal text.
Any issues with increasing the size of the window? Or even adding in the option to "maximize"?
This is something I don't mind working on myself and submitting a pull request.
Hello @markovchainz, absolutely no reason not to consider a PR adding this. We need to consider how we will handle the session recording, but this is a second step.
If you can look at the window resize or maximize option, it'd be great.
@markovchainz
I've personally found the terminal window to be a bit too small when there's a lot of terminal text.
I agree.
Any issues with increasing the size of the window? Or even adding in the option to "maximize"?
The main problem is how to send the 'window resize' to the SSH server through WebSocket since there's no protocol on top of WebSocket connection (currently just raw SSH over WebSocket).
@sixhills
It would also be good if the window could be moved.
This is a limitation of the Vuetify framework, it does not supports movable dialogs (https://vuetifyjs.com/en/components/dialogs/)
@markovchainz
Sounds good, I will get started and keep you posted.
If you need it now and can't wait for window resize in Web UI you can use a native SSH client which supports window resizing.
The implementation of SSH in Shellhub seems to be in raw bytes, a reference for the JSON version of the implementation with two types of messages (resize and command) seems to available in: https://mojotv.cn/2019/05/27/xtermjs-go#yaurm
The implementation of SSH in Shellhub seems to be in raw bytes, a reference for the JSON version of the implementation with two types of messages (resize and command) seems to available in: https://mojotv.cn/2019/05/27/xtermjs-go#yaurm
This is exactly what needs to be done