react-wheel-of-prizes icon indicating copy to clipboard operation
react-wheel-of-prizes copied to clipboard

Dependancies prevent use on react 17 or 18

Open f4hy opened this issue 2 years ago • 7 comments

Currently the dependency only allows use of react 16. React 17 and 18 are both out as of now.

f4hy avatar May 19 '22 03:05 f4hy

Just ran into this error myself. Is this something simple to do? I would like to help the dev update. LMK @shekharramola

SebTheRed avatar Oct 30 '22 01:10 SebTheRed

@shekharramola @f4hy @SebTheRed I've converted this project locally into modern typescript usable with React 18 (and have fixed a couple of small bugs on the way), I can make a PR to merge those changes into this project if there's still demand

RyanMan56 avatar Feb 12 '23 09:02 RyanMan56

@RyanMan56 , Yes, please. that could help many people here.

shekharramola avatar Feb 15 '23 13:02 shekharramola

@RyanMan56 HI, you can send a pull request ? You're just gonna save my life.

doubledeckwa avatar Mar 27 '24 09:03 doubledeckwa

@RyanMan56 HI, you can send a pull request ? You're just gonna save my life.

Good timing, you've caught me on my week off :) I'll raise the PR within the next couple of hours

RyanMan56 avatar Mar 27 '24 13:03 RyanMan56

@doubledeckwa I've tried running the latest master branch of this repo in a fresh Vite project running on React v18.2.0 and it seems to work fine now. And the other issues I mentioned have already been tackled.

But I have raised a PR adding TypeScript support and optional fontSize and outlineWidth props: https://github.com/shekharramola/react-wheel-of-prizes/pull/30

@shekharramola Please review when you get a chance

RyanMan56 avatar Mar 27 '24 14:03 RyanMan56

@RyanMan56 I am facing issue in running this package with react ^18.2.0. can you please how you ran it in your local machine with master branch. I tried to install it directly using npm i react-wheel-of-prizes

I tried using following commands

npm i https://github.com/shekharramola/react-wheel-of-prizes#master

npm i git+https://github.com/shekharramola/react-wheel-of-prizes.git#master

image

vatsal-crescentek avatar Apr 09 '24 07:04 vatsal-crescentek