flask-login-example icon indicating copy to clipboard operation
flask-login-example copied to clipboard

Note to author about outdated code

Open Swiftkilla opened this issue 7 years ago • 3 comments

Just a word of warning, some of your imports have been depreceated since recent version releases of Flask. Please consider updating the code to reflect the new method of importing or alternatively hide the source. I only say this as unsuspecting new devs who might try and use this code after installing Flask and relevant extension from newer versions.

Just a suggestion.

Swiftkilla avatar Aug 29 '18 18:08 Swiftkilla

Hello @Swiftkilla can you send the PR with updated imports? I don't use Python these days and away from its ecosystem. I will be more than happy to accept your contribution.

shekhargulati avatar Aug 29 '18 18:08 shekhargulati

Sure, will do when I have some spare time bud. No problem :)

Swiftkilla avatar Aug 30 '18 17:08 Swiftkilla

Looks that repo is well indexed:

https://stackoverflow.com/questions/59525220/which-package-should-i-install-for-flask-ext-login-and-flask-login

felipsmartins avatar Dec 30 '19 03:12 felipsmartins