extracted-loader icon indicating copy to clipboard operation
extracted-loader copied to clipboard

Any plan for you to support MiniCssExtractPlugin for Webpack 4?

Open rg-najera opened this issue 6 years ago • 5 comments

As per per extract-text-webpack-plugin readme "Since webpack v4 the extract-text-webpack-plugin should not be used for css. Use mini-css-extract-plugin instead."

This plugin might become absolute as a result, been enjoying using it when matching animations to load times and the like. Thanks for contributing to the community.

rg-najera avatar Jul 31 '18 20:07 rg-najera

I think it should just work

sheerun avatar Aug 10 '18 16:08 sheerun

I am messing around with linaria and my css isn't reloading on changes. Looking around for potential solutions I saw this but am getting some warnings:

(node:28964) DeprecationWarning: Tapable.apply is deprecated. Call apply on the plugin directly instead

If extracted-loader is still recommended, it would probably be good to make it work with mini-css-extract-plugin.

nodabladam avatar Mar 05 '20 01:03 nodabladam

@nodabladam I can try to fix it if you setup example repository that reproduces issue

sheerun avatar Mar 05 '20 09:03 sheerun

@sheerun For me when I just run the current with-next example here without any changes (other than adding cross-env to build) I get the problem trying to build:

C:\...\extracted-loader\examples\with-next>npm run build

> [email protected] build C:\Users\enalm\code\public\extracted-loader\examples\with-next
> cross-env NODE_ENV=production next build && next export && node bin/bundle

(node:13440) DeprecationWarning: Tapable.plugin is deprecated. Use new API on `.hooks` instead
(node:13440) DeprecationWarning: Tapable.apply is deprecated. Call apply on the plugin directly instead
Creating an optimized production build ..C:\...\extracted-loader\examples\with-next\node_modules\webpack\lib\Chunk.js:866
                throw new Error(
                ^

Error: Chunk.entrypoints: Use Chunks.groupsIterable and filter by instanceof Entrypoint instead

nodabladam avatar Mar 05 '20 17:03 nodabladam

current example is probably out of date, I'd need to create new one from scratch

sheerun avatar Mar 05 '20 17:03 sheerun