barycorrpy
barycorrpy copied to clipboard
shbhuk
Python version of Barycorr
Hi @shbhuk! Thanks a lot for this beautiful package. I had one request, though, that it was not obvious to me how to implement (but which apparently Jason Eastman did...
It would be really neat if this code could also do the backwards BJD conversion, like https://astroutils.astronomy.osu.edu/time/bjd2utc.html
A few ideas for Getting_started.ipynb - Should import barycorrpy - run the sample script - explain the correct outputs from the sample scripts - explain any warning flags if there...
Need to add command line interface, which would involve using arg parse for handling of the arguments to the barycorrpy function.
https://github.com/shbhuk/barycorrpy/blob/4f48f89980b5e2b3ebc8030a3c98211b24688f1b/barycorrpy/barycorrpy.py#L234 As implemented, if the input to get_bc_vel is a list of JDs (as a list or Time objects), then the BC for each is computed individually. This causes problems...
Astroquery v0.4.4 onward default id_type = None to search for major bodies first. Documentation should be updated here: https://github.com/shbhuk/barycorrpy/blob/4f48f89980b5e2b3ebc8030a3c98211b24688f1b/barycorrpy/SolarSystemBC.py#L183 The desired search behavior for small bodies is passed throughout barycorrpy...