MMM-RTSPStream icon indicating copy to clipboard operation
MMM-RTSPStream copied to clipboard

Published 20 hours ago • verified publisher icon shbatm

Review

Open KristjanESPERANTO opened this issue 1 year ago • 3 comments

I know you don't use the module anymore, but I still find it useful :slightly_smiling_face: I took a look at the code and have some suggestions for changes.

There are no functional changes, just optimizations like formatting, typos and dependency updates.

Notes:

  1. I would like to remove omxplayer since it is deprecated, but that would be too much for this PR. Maybe I'll do that with a later PR.
  2. By the way, the configuration helper is great. It is very nicely implemented. Although I would also like to get rid of the jquery dependency.

KristjanESPERANTO avatar Nov 21 '23 19:11 KristjanESPERANTO

Thanks, I'll try to take a look over the holidays.

shbatm avatar Nov 22 '23 09:11 shbatm

@shbatm: About which holidays are you talking about? 😅

KristjanESPERANTO avatar Jan 26 '24 17:01 KristjanESPERANTO

Thank you for the detailed answer :slightly_smiling_face:

I fully agree with removing OMXPlayer.

I'll put that and jquery on my long to-do list :slightly_smiling_face:

If you're going to try to keep maintaining, you can update the README to reflect that--it still shows it not being maintained.

At the moment I would not want to change the status as it is in the README ("I will accept PRs and leave the repo active"). I might check the issues from time to time and make a few small changes, but I don't want to make any promises :slightly_smiling_face:

KristjanESPERANTO avatar Jan 31 '24 20:01 KristjanESPERANTO