foundry.nix icon indicating copy to clipboard operation
foundry.nix copied to clipboard

Add integration test for PRs

Open shazow opened this issue 3 years ago • 3 comments

Too easy to break the build when merging fixes, e.g. #10 -> #11

shazow avatar Nov 23 '22 00:11 shazow

Currently, you have tiny inputs for the flake, and it's good that someone adds your flake as an input. What do you think about adding some other dependencies but only for CI?

Seems like they are unnecessary for the flake, so we shouldn't include any additional dependencies to the main flake. Should we create another flake only for CI? Or just use CI without nix magic (formatting, testing and so on)?

selfuryon avatar Nov 27 '23 00:11 selfuryon

@selfuryon I don't have strong feelings here, the bundle itself is comparatively large (50MB+) that I don't feel bad adding a few kb of dependencies.

A separate flake in a subdirectory just for testing could work too though, if it's convenient. :)

Overall, any amount of integration testing is better than nothing, so any approach is appreciated!

shazow avatar Nov 27 '23 17:11 shazow

Got that, I will try to do that this week :)

selfuryon avatar Nov 28 '23 15:11 selfuryon