apiclient icon indicating copy to clipboard operation
apiclient copied to clipboard

mysterious TODO in base.py

Open MattDMo opened this issue 8 years ago • 2 comments

base.py#L46 has a mysterious TODO comment:

    def _compose_url(self, path, params=None):
        # TODO: fix this, as per our conversation at Oct. 4, 2011, 05:10 UTC
        p = {self.API_KEY_PARAM: self.api_key}

        if params:
            p.update(params)

        return self.BASE_URL + path + '?' + urlencode(p)

Could you explain this to the general public (or just me, whichever) so we can think about a fix for whatever the problem is?

MattDMo avatar May 15 '16 12:05 MattDMo

Heh, good question. It's this commit https://github.com/shazow/apiclient/commit/5c9ea21117918da69afb65931df1a0369303d452 by @wolever. Any idea, wolever?

shazow avatar May 15 '16 22:05 shazow

That is a very good question… alas, I have no idea what our conversation on Oct 4th, 2011 was about.

Maybe I was hoping I'd have a @hyfen-esque database to search one day?

wolever avatar May 16 '16 21:05 wolever